mathias/gitea-mcp
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

auth: CallerMiddleware header priority order is undocumented #10

New Issue
Open
opened 2026-05-14 08:44:21 +00:00 by mathias · 0 comments
mathias commented 2026-05-14 08:44:21 +00:00
Owner
Copy Link

CallerMiddleware checks X-Auth-Request-User first, then falls back to X-Forwarded-User. If a future auth proxy sets both headers (e.g. oauth2-proxy in some configs does), behaviour is undefined and untested.

File: internal/auth/caller.go:10-18

Suggestions:

  • Add a comment documenting which header takes precedence and why
  • Add a unit test covering the both-present scenario
  • Consider logging a warning when both are present and differ
`CallerMiddleware` checks `X-Auth-Request-User` first, then falls back to `X-Forwarded-User`. If a future auth proxy sets both headers (e.g. oauth2-proxy in some configs does), behaviour is undefined and untested. **File:** `internal/auth/caller.go:10-18` **Suggestions:** - Add a comment documenting which header takes precedence and why - Add a unit test covering the both-present scenario - Consider logging a warning when both are present and differ
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
mathias
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mathias/gitea-mcp#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?