feat(mcp): optional bearer-token auth via SUPERVISOR_MCP_TOKEN
All checks were successful
CI / Lint / Test / Vet (push) Successful in 10s
CI / Mirror to GitHub (push) Successful in 3s

Enables exposing the supervisor MCP via Tailscale Funnel for claude.ai
custom-connector tests. Auth is opt-in: empty SUPERVISOR_MCP_TOKEN
preserves the existing unauthenticated behavior for tailnet-internal
callers and local dev.

When the token is set, every request must carry
"Authorization: Bearer <token>" or it is rejected with HTTP 401 and a
JSON-RPC -32001 error. Comparison uses crypto/subtle.ConstantTimeCompare;
the token value and the supplied header are never logged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mathias Bergqvist
2026-05-04 07:31:29 +02:00
parent 1b9c4905a5
commit 928f23ab1b
6 changed files with 93 additions and 9 deletions

View File

@@ -111,6 +111,7 @@ The supervisor probes connectivity at call time:
| `SUPERVISOR_SESSIONS_DIR` | `./brain/sessions` | JSONL session logs | | `SUPERVISOR_SESSIONS_DIR` | `./brain/sessions` | JSONL session logs |
| `INGEST_BASE_URL` | `http://localhost:3300` | Supervisor → ingestion | | `INGEST_BASE_URL` | `http://localhost:3300` | Supervisor → ingestion |
| `LITELLM_BASE_URL` | — | LiteLLM proxy for Tier 2 model routing | | `LITELLM_BASE_URL` | — | LiteLLM proxy for Tier 2 model routing |
| `SUPERVISOR_MCP_TOKEN` | — | Optional bearer token for the supervisor MCP HTTP endpoint; when empty, no auth is enforced |
## Phase 2 (planned) ## Phase 2 (planned)

View File

@@ -150,7 +150,7 @@ func main() {
BrainDir: cfg.BrainDir, BrainDir: cfg.BrainDir,
})) }))
srv := mcp.NewServer(reg) srv := mcp.NewServer(reg, cfg.MCPAuthToken)
mux := http.NewServeMux() mux := http.NewServeMux()
mux.Handle("/mcp", srv) mux.Handle("/mcp", srv)

View File

@@ -13,6 +13,7 @@ type Config struct {
KBRetrievalURL string // KB_RETRIEVAL_URL — base URL for brain_search KBRetrievalURL string // KB_RETRIEVAL_URL — base URL for brain_search
SessionsDir string // SUPERVISOR_SESSIONS_DIR, default ./brain/sessions SessionsDir string // SUPERVISOR_SESSIONS_DIR, default ./brain/sessions
BrainDir string // SUPERVISOR_BRAIN_DIR, default ./brain BrainDir string // SUPERVISOR_BRAIN_DIR, default ./brain
MCPAuthToken string // SUPERVISOR_MCP_TOKEN — optional bearer token for MCP HTTP; empty disables auth
} }
func Load() (Config, error) { func Load() (Config, error) {
@@ -28,6 +29,7 @@ func Load() (Config, error) {
cfg.KBRetrievalURL = envOr("KB_RETRIEVAL_URL", "") cfg.KBRetrievalURL = envOr("KB_RETRIEVAL_URL", "")
cfg.SessionsDir = envOr("SUPERVISOR_SESSIONS_DIR", "./brain/sessions") cfg.SessionsDir = envOr("SUPERVISOR_SESSIONS_DIR", "./brain/sessions")
cfg.BrainDir = envOr("SUPERVISOR_BRAIN_DIR", "./brain") cfg.BrainDir = envOr("SUPERVISOR_BRAIN_DIR", "./brain")
cfg.MCPAuthToken = os.Getenv("SUPERVISOR_MCP_TOKEN")
return cfg, nil return cfg, nil
} }

View File

@@ -16,6 +16,7 @@ func TestLoadDefaults(t *testing.T) {
t.Setenv("INGEST_BASE_URL", "") t.Setenv("INGEST_BASE_URL", "")
t.Setenv("SUPERVISOR_SESSIONS_DIR", "") t.Setenv("SUPERVISOR_SESSIONS_DIR", "")
t.Setenv("SUPERVISOR_BRAIN_DIR", "") t.Setenv("SUPERVISOR_BRAIN_DIR", "")
t.Setenv("SUPERVISOR_MCP_TOKEN", "")
cfg, err := config.Load() cfg, err := config.Load()
require.NoError(t, err) require.NoError(t, err)
@@ -25,6 +26,7 @@ func TestLoadDefaults(t *testing.T) {
assert.Equal(t, "http://localhost:3300", cfg.IngestBaseURL) assert.Equal(t, "http://localhost:3300", cfg.IngestBaseURL)
assert.Equal(t, "./brain/sessions", cfg.SessionsDir) assert.Equal(t, "./brain/sessions", cfg.SessionsDir)
assert.Equal(t, "./brain", cfg.BrainDir) assert.Equal(t, "./brain", cfg.BrainDir)
assert.Equal(t, "", cfg.MCPAuthToken)
} }
func TestLoadFromEnv(t *testing.T) { func TestLoadFromEnv(t *testing.T) {
@@ -32,6 +34,7 @@ func TestLoadFromEnv(t *testing.T) {
t.Setenv("LITELLM_BASE_URL", "http://localhost:4000") t.Setenv("LITELLM_BASE_URL", "http://localhost:4000")
t.Setenv("LITELLM_API_KEY", "test-key") t.Setenv("LITELLM_API_KEY", "test-key")
t.Setenv("SUPERVISOR_CONFIG_DIR", "/etc/supervisor") t.Setenv("SUPERVISOR_CONFIG_DIR", "/etc/supervisor")
t.Setenv("SUPERVISOR_MCP_TOKEN", "secret-token")
cfg, err := config.Load() cfg, err := config.Load()
require.NoError(t, err) require.NoError(t, err)
@@ -39,4 +42,5 @@ func TestLoadFromEnv(t *testing.T) {
assert.Equal(t, "http://localhost:4000", cfg.LiteLLMBaseURL) assert.Equal(t, "http://localhost:4000", cfg.LiteLLMBaseURL)
assert.Equal(t, "test-key", cfg.LiteLLMAPIKey) assert.Equal(t, "test-key", cfg.LiteLLMAPIKey)
assert.Equal(t, "/etc/supervisor", cfg.ConfigDir) assert.Equal(t, "/etc/supervisor", cfg.ConfigDir)
assert.Equal(t, "secret-token", cfg.MCPAuthToken)
} }

View File

@@ -2,8 +2,11 @@ package mcp
import ( import (
"context" "context"
"crypto/subtle"
"encoding/json" "encoding/json"
"log/slog"
"net/http" "net/http"
"strings"
"github.com/mathiasbq/supervisor/internal/registry" "github.com/mathiasbq/supervisor/internal/registry"
) )
@@ -29,14 +32,22 @@ type rpcError struct {
// Server is an HTTP handler implementing the MCP JSON-RPC protocol. // Server is an HTTP handler implementing the MCP JSON-RPC protocol.
type Server struct { type Server struct {
reg *registry.Registry reg *registry.Registry
token string
} }
func NewServer(reg *registry.Registry) *Server { // NewServer constructs an MCP HTTP handler. If token is non-empty, every
return &Server{reg: reg} // request must carry "Authorization: Bearer <token>" or it is rejected with
// HTTP 401 and JSON-RPC error -32001. Empty token disables auth (default).
func NewServer(reg *registry.Registry, token string) *Server {
return &Server{reg: reg, token: token}
} }
func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) { func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
if !s.checkAuth(w, r) {
return
}
var req request var req request
if err := json.NewDecoder(r.Body).Decode(&req); err != nil { if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeError(w, nil, -32700, "parse error") writeError(w, nil, -32700, "parse error")
@@ -93,6 +104,29 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
}) })
} }
// checkAuth verifies the bearer token when one is configured. Returns true if
// the request may proceed, false if it has been rejected (401 already written).
func (s *Server) checkAuth(w http.ResponseWriter, r *http.Request) bool {
if s.token == "" {
return true
}
const prefix = "Bearer "
hdr := r.Header.Get("Authorization")
if !strings.HasPrefix(hdr, prefix) ||
subtle.ConstantTimeCompare([]byte(hdr[len(prefix):]), []byte(s.token)) != 1 {
slog.Warn("mcp auth rejected", "remote", r.RemoteAddr, "method", r.Method)
w.Header().Set("Content-Type", "application/json")
w.WriteHeader(http.StatusUnauthorized)
_ = json.NewEncoder(w).Encode(response{
JSONRPC: "2.0",
Error: &rpcError{Code: -32001, Message: "unauthorized"},
})
return false
}
return true
}
func writeError(w http.ResponseWriter, id any, code int, msg string) { func writeError(w http.ResponseWriter, id any, code int, msg string) {
w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Type", "application/json")
_ = json.NewEncoder(w).Encode(response{ _ = json.NewEncoder(w).Encode(response{

View File

@@ -23,7 +23,7 @@ func jsonBody(t *testing.T, v any) *bytes.Buffer {
func TestMCPInitialize(t *testing.T) { func TestMCPInitialize(t *testing.T) {
reg := registry.New() reg := registry.New()
srv := mcp.NewServer(reg) srv := mcp.NewServer(reg, "")
req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{ req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{
"jsonrpc": "2.0", "jsonrpc": "2.0",
@@ -45,7 +45,7 @@ func TestMCPInitialize(t *testing.T) {
func TestMCPToolsList(t *testing.T) { func TestMCPToolsList(t *testing.T) {
reg := registry.New() reg := registry.New()
srv := mcp.NewServer(reg) srv := mcp.NewServer(reg, "")
req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{ req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{
"jsonrpc": "2.0", "id": 2, "method": "tools/list", "params": map[string]any{}, "jsonrpc": "2.0", "id": 2, "method": "tools/list", "params": map[string]any{},
@@ -63,7 +63,7 @@ func TestMCPToolsList(t *testing.T) {
func TestMCPUnknownMethod(t *testing.T) { func TestMCPUnknownMethod(t *testing.T) {
reg := registry.New() reg := registry.New()
srv := mcp.NewServer(reg) srv := mcp.NewServer(reg, "")
req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{ req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{
"jsonrpc": "2.0", "id": 3, "method": "unknown/method", "params": map[string]any{}, "jsonrpc": "2.0", "id": 3, "method": "unknown/method", "params": map[string]any{},
@@ -80,7 +80,7 @@ func TestMCPUnknownMethod(t *testing.T) {
func TestMCPNotificationKnownMethodGetsNoResponseBody(t *testing.T) { func TestMCPNotificationKnownMethodGetsNoResponseBody(t *testing.T) {
reg := registry.New() reg := registry.New()
srv := mcp.NewServer(reg) srv := mcp.NewServer(reg, "")
// JSON-RPC 2.0 notification: "id" field absent. Per spec, server MUST NOT // JSON-RPC 2.0 notification: "id" field absent. Per spec, server MUST NOT
// reply. notifications/initialized is part of the standard MCP handshake. // reply. notifications/initialized is part of the standard MCP handshake.
@@ -97,9 +97,52 @@ func TestMCPNotificationKnownMethodGetsNoResponseBody(t *testing.T) {
"notifications must not receive a response body") "notifications must not receive a response body")
} }
func TestMCPAuth(t *testing.T) {
const token = "s3cr3t"
cases := []struct {
name string
token string
authHeader string
wantStatus int
}{
{"no token configured passes without header", "", "", http.StatusOK},
{"correct bearer passes", token, "Bearer " + token, http.StatusOK},
{"wrong bearer rejected", token, "Bearer wrong", http.StatusUnauthorized},
{"missing header rejected", token, "", http.StatusUnauthorized},
{"wrong scheme rejected", token, "Basic " + token, http.StatusUnauthorized},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
reg := registry.New()
srv := mcp.NewServer(reg, tc.token)
req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{
"jsonrpc": "2.0", "id": 1, "method": "initialize", "params": map[string]any{},
}))
req.Header.Set("Content-Type", "application/json")
if tc.authHeader != "" {
req.Header.Set("Authorization", tc.authHeader)
}
rr := httptest.NewRecorder()
srv.ServeHTTP(rr, req)
assert.Equal(t, tc.wantStatus, rr.Code)
if tc.wantStatus == http.StatusUnauthorized {
var resp map[string]any
require.NoError(t, json.Unmarshal(rr.Body.Bytes(), &resp))
rpcErr, ok := resp["error"].(map[string]any)
require.True(t, ok, "expected error object in response")
assert.Equal(t, float64(-32001), rpcErr["code"])
}
})
}
}
func TestMCPNotificationUnknownMethodGetsNoResponseBody(t *testing.T) { func TestMCPNotificationUnknownMethodGetsNoResponseBody(t *testing.T) {
reg := registry.New() reg := registry.New()
srv := mcp.NewServer(reg) srv := mcp.NewServer(reg, "")
req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{ req := httptest.NewRequest(http.MethodPost, "/mcp", jsonBody(t, map[string]any{
"jsonrpc": "2.0", "jsonrpc": "2.0",