// internal/skills/review/skill.go
package review

import (
	"context"
	"encoding/json"

	iexec "github.com/mathiasbq/supervisor/internal/exec"
	"github.com/mathiasbq/supervisor/internal/registry"
)

// ExecutorFn is the function signature for running a worker subprocess.
type ExecutorFn func(ctx context.Context, req iexec.Request) (iexec.Result, error)

// Config holds dependencies for the review skill.
type Config struct {
	SkillPrompt   string
	DefaultModel  string
	ExecutorFn    ExecutorFn
	SessionsDir   string
	IngestBaseURL string // optional: base URL of ingestion server for brain context
}

// Skill implements the review MCP tool.
type Skill struct{ cfg Config }

// New creates a new review Skill.
func New(cfg Config) *Skill { return &Skill{cfg: cfg} }

// Name returns the skill identifier.
func (s *Skill) Name() string { return "review" }

// Tools returns the MCP tool definitions for this skill.
func (s *Skill) Tools() []registry.ToolDef {
	schema := func(required []string, props map[string]any) json.RawMessage {
		b, _ := json.Marshal(map[string]any{"type": "object", "required": required, "properties": props})
		return b
	}
	str := map[string]any{"type": "string"}
	return []registry.ToolDef{
		{
			Name:        "review",
			Description: "Perform a structured code review of the specified files. Returns findings with severity levels.",
			InputSchema: schema(
				[]string{"project_root", "files"},
				map[string]any{
					"project_root": str,
					"files":        map[string]any{"type": "array", "items": map[string]any{"type": "string"}},
					"context":      str,
					"model":        str,
					"session_id":   str,
				},
			),
		},
	}
}