ce45592730
Drop the three-layer Claude subprocess orchestration (local model →
Claude verifier → cloud escalation). Skills now call LiteLLM directly
and return plain text to Claude Code, which decides what to do with it.
- Delete executor, orchestrator, verifier, result, attempts packages
- Simplify LiteLLMExecutor: Run(Request)→Result becomes Complete(model,sys,user)→(string,int64,error)
- Replace ExecutorFn with CompleteFunc in all 6 skill configs
- Rewrite all skill handlers to call Complete and return {"text","model","duration_ms"}
- Simplify config/models: remove Verifier/LlamaSwapURL, add ModelFor
- Bump version to v0.5.0
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
54 lines
1.7 KiB
Go
54 lines
1.7 KiB
Go
// internal/skills/review/handlers_test.go
|
|
package review_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/mathiasbq/supervisor/internal/skills/review"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestReviewToolRegistered(t *testing.T) {
|
|
sk := review.New(review.Config{SkillPrompt: "review rules"})
|
|
names := make([]string, 0)
|
|
for _, tool := range sk.Tools() {
|
|
names = append(names, tool.Name)
|
|
}
|
|
assert.Contains(t, names, "review")
|
|
}
|
|
|
|
func TestReviewRequiresProjectRoot(t *testing.T) {
|
|
sk := review.New(review.Config{SkillPrompt: "r"})
|
|
_, err := sk.Handle(context.Background(), "review", json.RawMessage(`{"files":["main.go"]}`))
|
|
assert.ErrorContains(t, err, "project_root")
|
|
}
|
|
|
|
func TestReviewRequiresFiles(t *testing.T) {
|
|
sk := review.New(review.Config{SkillPrompt: "r"})
|
|
_, err := sk.Handle(context.Background(), "review", json.RawMessage(`{"project_root":"/tmp"}`))
|
|
assert.ErrorContains(t, err, "files")
|
|
}
|
|
|
|
func TestReviewCallsCompleteFunc(t *testing.T) {
|
|
var capturedTask string
|
|
fakeFn := func(_ context.Context, _, _, user string) (string, int64, error) {
|
|
capturedTask = user
|
|
return "2 warnings found: missing error handling at line 42", 80, nil
|
|
}
|
|
|
|
sk := review.New(review.Config{SkillPrompt: "review rules", CompleteFunc: fakeFn, SessionsDir: t.TempDir()})
|
|
out, err := sk.Handle(context.Background(), "review", json.RawMessage(
|
|
`{"project_root":"/tmp/proj","files":["internal/foo/foo.go"],"context":"PR: add Foo helper"}`,
|
|
))
|
|
require.NoError(t, err)
|
|
assert.Contains(t, capturedTask, "internal/foo/foo.go")
|
|
assert.Contains(t, capturedTask, "PR: add Foo helper")
|
|
|
|
var result map[string]any
|
|
require.NoError(t, json.Unmarshal(out, &result))
|
|
assert.Contains(t, result["text"], "2 warnings found")
|
|
}
|