75685e7b67
Adds a two-dimensional address (wing, hall) to brain notes. A wing is a
topic domain (e.g. jepa-fx, hyperguild); a hall is one of a closed
vocabulary of memory types (facts, decisions, failures, hypotheses,
sources). Notes route to brain/wiki/<wing>/<hall>/<slug>.md with
wing/hall/created_at YAML frontmatter, making the directory a valid
Obsidian vault.
Changes:
- new package ingestion/internal/brain (NotePath, ValidHalls, Sanitise,
BuildWingIndex, BuildAllWingIndexes)
- api.WriteNote refactored to WriteNoteOptions; wing+hall routes to
brain/wiki/, otherwise falls back to brain/knowledge/ (legacy)
- search.Query → QueryOptions with optional Wing/Hall filtering; Result
carries wing/hall extracted from frontmatter or path segments
- MCP tools brain_write and brain_query gain optional wing/hall params
(hall enum-validated); new brain_index tool regenerates _index.md MOC
- POST /index REST endpoint mirrors brain_index
- brain_write auto-rebuilds the wing's _index.md after a wing+hall write
- scripts/migrate-brain-halls.sh migrates flat brain/wiki/{concepts,entities}/
into the new layout (dry-run by default, --commit applies)
All existing tests pass; new tests cover wing/hall write routing, scope
filtering, invalid hall rejection, _index.md generation, and migration
script paths.
Closes hyperguild#1.
96 lines
3.4 KiB
Go
96 lines
3.4 KiB
Go
// ingestion/internal/search/search_test.go
|
|
package search_test
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/mathiasbq/hyperguild/ingestion/internal/search"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSearch_ReturnsMatchingPages(t *testing.T) {
|
|
dir := t.TempDir()
|
|
require.NoError(t, os.MkdirAll(filepath.Join(dir, "knowledge"), 0o755))
|
|
|
|
require.NoError(t, os.WriteFile(
|
|
filepath.Join(dir, "knowledge", "retry-logic.md"),
|
|
[]byte("---\ntitle: Retry Logic\ndomain: software\n---\n\nRetry logic handles transient failures by re-attempting operations.\n"),
|
|
0o644,
|
|
))
|
|
require.NoError(t, os.WriteFile(
|
|
filepath.Join(dir, "knowledge", "database.md"),
|
|
[]byte("---\ntitle: Database\ndomain: software\n---\n\nA database stores structured data.\n"),
|
|
0o644,
|
|
))
|
|
|
|
results, err := search.Query(dir, search.QueryOptions{Query: "retry transient", Limit: 5})
|
|
require.NoError(t, err)
|
|
require.Len(t, results, 1)
|
|
assert.Equal(t, "knowledge/retry-logic.md", results[0].Path)
|
|
assert.Equal(t, "Retry Logic", results[0].Title)
|
|
assert.Greater(t, results[0].Score, 0)
|
|
assert.Contains(t, results[0].Excerpt, "Retry")
|
|
}
|
|
|
|
func TestSearch_WingHallScoping(t *testing.T) {
|
|
dir := t.TempDir()
|
|
for _, p := range []struct{ rel, body string }{
|
|
{"wiki/jepa-fx/decisions/val-vol.md", "---\nwing: jepa-fx\nhall: decisions\n---\nval-vol-r2 keyword.\n"},
|
|
{"wiki/jepa-fx/facts/architecture.md", "---\nwing: jepa-fx\nhall: facts\n---\nval-vol-r2 keyword in facts.\n"},
|
|
{"wiki/hyperguild/decisions/routing.md", "---\nwing: hyperguild\nhall: decisions\n---\nval-vol-r2 reference.\n"},
|
|
{"knowledge/loose.md", "---\n---\nval-vol-r2 in knowledge.\n"},
|
|
} {
|
|
full := filepath.Join(dir, p.rel)
|
|
require.NoError(t, os.MkdirAll(filepath.Dir(full), 0o755))
|
|
require.NoError(t, os.WriteFile(full, []byte(p.body), 0o644))
|
|
}
|
|
|
|
// No filter: walk both knowledge/ and wiki/ — all 4 match.
|
|
got, err := search.Query(dir, search.QueryOptions{Query: "val-vol-r2", Limit: 10})
|
|
require.NoError(t, err)
|
|
assert.Len(t, got, 4)
|
|
|
|
// Wing scope: 2 jepa-fx hits, no hyperguild, no knowledge.
|
|
got, err = search.Query(dir, search.QueryOptions{Query: "val-vol-r2", Limit: 10, Wing: "jepa-fx"})
|
|
require.NoError(t, err)
|
|
require.Len(t, got, 2)
|
|
for _, r := range got {
|
|
assert.Equal(t, "jepa-fx", r.Wing)
|
|
}
|
|
|
|
// Wing+Hall scope: 1 hit.
|
|
got, err = search.Query(dir, search.QueryOptions{Query: "val-vol-r2", Limit: 10, Wing: "jepa-fx", Hall: "decisions"})
|
|
require.NoError(t, err)
|
|
require.Len(t, got, 1)
|
|
assert.Equal(t, "jepa-fx", got[0].Wing)
|
|
assert.Equal(t, "decisions", got[0].Hall)
|
|
assert.Equal(t, "wiki/jepa-fx/decisions/val-vol.md", got[0].Path)
|
|
|
|
// Invalid hall rejected.
|
|
_, err = search.Query(dir, search.QueryOptions{Query: "x", Wing: "jepa-fx", Hall: "garbage"})
|
|
require.Error(t, err)
|
|
|
|
// Hall without wing rejected.
|
|
_, err = search.Query(dir, search.QueryOptions{Query: "x", Hall: "facts"})
|
|
require.Error(t, err)
|
|
}
|
|
|
|
func TestSearch_RespectsLimit(t *testing.T) {
|
|
dir := t.TempDir()
|
|
require.NoError(t, os.MkdirAll(filepath.Join(dir, "knowledge"), 0o755))
|
|
for i := 0; i < 5; i++ {
|
|
require.NoError(t, os.WriteFile(
|
|
filepath.Join(dir, "knowledge", fmt.Sprintf("page-%d.md", i)),
|
|
[]byte(fmt.Sprintf("---\ntitle: Page %d\n---\n\nThis page mentions retry.\n", i)),
|
|
0o644,
|
|
))
|
|
}
|
|
results, err := search.Query(dir, search.QueryOptions{Query: "retry", Limit: 3})
|
|
require.NoError(t, err)
|
|
assert.LessOrEqual(t, len(results), 3)
|
|
}
|